Re: [PATCH RFC 6/6] ARM: dts: am335x-boneblack: Use new binding for HDMI

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Mon, Mar 02, 2015 at 02:28:40PM +0200, Tomi Valkeinen wrote:
> On 26/02/15 16:55, Jyri Sarha wrote:
> > Use new binding for the external tda19988 HDMI encoder.
> > 
> > Signed-off-by: Jyri Sarha <jsarha@xxxxxx>
> > ---
> >  arch/arm/boot/dts/am335x-boneblack.dts | 20 +++++++++++++++-----
> >  1 file changed, 15 insertions(+), 5 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/am335x-boneblack.dts b/arch/arm/boot/dts/am335x-boneblack.dts
> > index 5c42d25..eadbba3 100644
> > --- a/arch/arm/boot/dts/am335x-boneblack.dts
> > +++ b/arch/arm/boot/dts/am335x-boneblack.dts
> > @@ -68,16 +68,26 @@
> >  
> >  &lcdc {
> >  	status = "okay";
> > +	port {
> > +		lcdc_0: endpoint@0 {
> > +			remote-endpoint = <&hdmi_0>;
> > +		};
> > +	};
> >  };
> >  
> > -/ {
> > -	hdmi {
> > -		compatible = "ti,tilcdc,slave";
> > -		i2c = <&i2c0>;
> > +&i2c0 {
> > +	tda19988 {
> > +		compatible = "nxp,tda998x";
> > +		reg = <0x70>;
> >  		pinctrl-names = "default", "off";
> >  		pinctrl-0 = <&nxp_hdmi_bonelt_pins>;
> >  		pinctrl-1 = <&nxp_hdmi_bonelt_off_pins>;
> > -		status = "okay";
> > +
> > +		port {
> > +			hdmi_0: endpoint@0 {
> > +				remote-endpoint = <&lcdc_0>;
> > +			};
> > +		};
> >  	};
> >  };
> 
> This is missing the output of tda998x. It should have two ports, input
> and output, output going to hdmi-connector.

We don't have that kind of level of modelling in DRM right now - as far
as DRM is concerned, the tda998x is both the encoder _and_ the connector
since it supplies both functionalities.

We did discuss this ages ago, but afaik no concensus was reached how to
model physical connectors in DT, so it never moved forward in DRM (and
besides, everyone seems to be off doing their own thing when it comes
to writing DT descriptions for video hardware.)

-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux