On Fri, Feb 27, 2015 at 11:52:54PM +0000, Iyappan Subramanian wrote: > On Fri, Feb 27, 2015 at 12:33 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote: > > On Friday 27 February 2015 12:08:29 Iyappan Subramanian wrote: > >> diff --git a/arch/arm64/boot/dts/apm/apm-storm.dtsi b/arch/arm64/boot/dts/apm/apm-storm.dtsi > >> index f1ad9c2..a857794 100644 > >> --- a/arch/arm64/boot/dts/apm/apm-storm.dtsi > >> +++ b/arch/arm64/boot/dts/apm/apm-storm.dtsi > >> @@ -622,7 +622,7 @@ > >> }; > >> > >> sgenet0: ethernet@1f210000 { > >> - compatible = "apm,xgene-enet"; > >> + compatible = "apm,xgene1-sgenet"; > >> status = "disabled"; > >> reg = <0x0 0x1f210000 0x0 0xd100>, > >> <0x0 0x1f200000 0x0 0Xc300>, > >> > > > > This will break booting the new dtb on older kernels, right? > > This will not break booting older kernels. In fact, this will fix it, > by having the specific binding, > older kernel that does not have support for these interfaces, will not > call probe. > > For example, 3.17 kernel that does not have support for SGMII based 1G > and XFI 10G interfaces > will not probe these interfaces when booted with newer dtb. I'm guessing that in the existing DTBs, these nodes are always disabled? If that's the case then we don't have a problem; we'll never probe these nodes for an existing DTB. Mark. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html