On Fri, Feb 27, 2015 at 11:58:28PM +0000, Iyappan Subramanian wrote: > On Fri, Feb 27, 2015 at 12:15 PM, Mark Rutland <mark.rutland@xxxxxxx> wrote: > > On Fri, Feb 27, 2015 at 08:08:28PM +0000, Iyappan Subramanian wrote: > >> Signed-off-by: Iyappan Subramanian <isubramanian@xxxxxxx> > >> Signed-off-by: Keyur Chudgar <kchudgar@xxxxxxx> > >> Tested-by: Mark Langsdorf <mlangsdo@xxxxxxxxxx> > >> --- > >> Documentation/devicetree/bindings/net/apm-xgene-enet.txt | 3 ++- > >> 1 file changed, 2 insertions(+), 1 deletion(-) > >> > >> diff --git a/Documentation/devicetree/bindings/net/apm-xgene-enet.txt b/Documentation/devicetree/bindings/net/apm-xgene-enet.txt > >> index cfcc527..5355996 100644 > >> --- a/Documentation/devicetree/bindings/net/apm-xgene-enet.txt > >> +++ b/Documentation/devicetree/bindings/net/apm-xgene-enet.txt > >> @@ -4,7 +4,8 @@ Ethernet nodes are defined to describe on-chip ethernet interfaces in > >> APM X-Gene SoC. > >> > >> Required properties for all the ethernet interfaces: > >> -- compatible: Should be "apm,xgene-enet" > >> +- compatible: Should be "apm,xgene-enet", "apm,xgene1-sgenet" or > >> + "apm,xgene1-xgenet" > > > > Please format this as a list. It'll be easier to read, and you can add > > more later. > > Thanks. I will do that. > > > > > What are the diffences between these variants? > > apm,xgene-enet - binding for RGMII based 1G interface > apm,xgene1-sgenet - binding for SGMII based 1G interface > apm,xgene1-xgenet - binding for XFI based 10G interface I see. If you could keep notes to this effect in the list, that would help to keep this obvious. Thanks, Mark. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
