Hi, On Wed, Jun 12, 2024 at 08:10:30PM GMT, Diederik de Haas wrote: > On Wednesday, 12 June 2024 19:15:45 CEST Sebastian Reichel wrote: > > diff --git a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi > > b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi index > > 9edbcfe778ca..e7e1b456b9b9 100644 > > --- a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi > > +++ b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi > > @@ -1239,6 +1239,27 @@ jpeg_enc3_mmu: iommu@fdbac800 { > > #iommu-cells = <0>; > > }; > > > > + vpu: video-codec@fdb50000 { > > + compatible = "rockchip,rk3588-vpu121", > > "rockchip,rk3568-vpu"; + reg = <0x0 0xfdb50000 0x0 0x800>; > > + interrupts = <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH 0>; > > + interrupt-names = "vdpu"; > > + clocks = <&cru ACLK_VPU>, <&cru HCLK_VPU>; > > + clock-names = "aclk", "hclk"; > > + iommus = <&vpu_mmu>; > > + power-domains = <&power RK3588_PD_VDPU>; > > + }; > > + > > + vpu_mmu: iommu@fdb50800 { > > + compatible = "rockchip,rk3588-iommu", > > "rockchip,rk3568-iommu"; + reg = <0x0 0xfdb50800 0x0 0x40>; > > + interrupts = <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH 0>; > > + clock-names = "aclk", "iface"; > > + clocks = <&cru ACLK_VPU>, <&cru HCLK_VPU>; > > + power-domains = <&power RK3588_PD_VDPU>; > > + #iommu-cells = <0>; > > + }; > > + > > av1d: video-codec@fdc70000 { > > Shouldn't these nodes come *before* > jpeg_enc0: video-codec@fdba0000 > As fdb50000 is lower then fdba0000? Of course. I will fix that in v6. -- Sebastian
Attachment:
signature.asc
Description: PGP signature