On Tue, Jun 11, 2024 at 8:19 PM Andreas Kemnade <andreas@xxxxxxxxxxxx> wrote: > hmm, that might be board specific stuff, maybe keep them as they are in the > twl6030.dtsi and override them in board specific dts files if needed. We could do that, since we have no datasheet publicly available for 6032, I thought it would be better to stick to values which are known to be working hence using downstream values. Anything mentioned in the BT200 kernel, we could update it with those values. > And is there any reason why you left out the pwm stuff? Didn't need it for espresso, but will add in v2. > I think the twl6030.dtsi and twl6032.dtsi should be as similar as possible. Agreed. But same min/max values as well? -- Best Regards, Mithil