Hi Benjamin, On Tue, Jun 11, 2024 at 01:57:24PM +0200, Benjamin Mugnier wrote: > Hi Sakari, > > On 6/11/24 10:21, Sakari Ailus wrote: > > Hi Benjamin, > > > > On Mon, Jun 10, 2024 at 05:08:15PM +0200, Benjamin Mugnier wrote: > >> Preserve user space retro compatibility after the device rename. > >> > >> Signed-off-by: Benjamin Mugnier <benjamin.mugnier@xxxxxxxxxxx> > >> --- > >> drivers/media/i2c/vgxy61.c | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/drivers/media/i2c/vgxy61.c b/drivers/media/i2c/vgxy61.c > >> index ca3b43608dad..c85f356946ca 100644 > >> --- a/drivers/media/i2c/vgxy61.c > >> +++ b/drivers/media/i2c/vgxy61.c > >> @@ -1898,3 +1898,4 @@ MODULE_AUTHOR("Mickael Guene <mickael.guene@xxxxxx>"); > >> MODULE_AUTHOR("Sylvain Petinot <sylvain.petinot@xxxxxxxxxxx>"); > >> MODULE_DESCRIPTION("VGXY61 camera subdev driver"); > >> MODULE_LICENSE("GPL"); > >> +MODULE_ALIAS("platform:st-vgxy61"); > > > > Perhaps just "st-vgxy61" so that the module still loads if someone loads it > > explicitly? That's what you'd want, right, as the old compatible string > > will remain? > > > > Yes it is for explicit loading. I'll remove the "platform" prefix. > > But maybe I'm overthinking and I could just remove the MODULE_ALIAS() > completely from this series. What do you think ? Most of the time the modules are loaded based on devices found, so this would likely not change things much. Up to you. -- Kind regards, Sakari Ailus