On Tue, Jun 11, 2024 at 12:28 PM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: > > On 11/06/2024 05:53, Kanak Shilledar wrote: > > Convert the Broadcom BCM63138 Processor Monitor Bus to newer DT > > schema. Created DT schema based on the .txt file which had `compatible`, > > `reg` and `"#reset-cells" as required properties. > > Added one line description which was missing in the original .txt file. > > Added Philipp Zabel as the maintainer (took from MAINTAINERS file). > > One of the necessary steps EVERYTIME you make conversion of some random > binding is to grep. git grep. You grep for stale paths and usage of > compatible in DTS. Sometimes you find nothing, sometimes you would find > something. > > `git grep bcm63138-pmb` gives you: > 1. stale path which you did not fix, > 2. duplicated schema... There is `brcm,bcm63138-pmb` defined in "/power/brcm,bcm-pmb.yaml" and "/reset/brcm,bcm63138-pmb.txt" but they both are for different purposes. By stale path are you referring that I will need to convert "/arm/bcm/brcm,bcm63138.txt" to DT Schema as well? > Best regards, > Krzysztof >