Hi Niklas, On Mon, Jun 10, 2024 at 1:32 PM Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> wrote: > Add support for R-Car V4M. The V4M is similar to V4H and uses the ISP > Channel Selector as its only possible video input source. Reuse and > rename the info structure from V4H to cover all current Gen4 SoCs. > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> > --- > * Changes since v1 > - Create a shared Gen4 info strucutre. Thanks for the update! Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > --- a/drivers/media/platform/renesas/rcar-vin/rcar-core.c > +++ b/drivers/media/platform/renesas/rcar-vin/rcar-core.c > @@ -1283,7 +1283,7 @@ static const struct rvin_info rcar_info_r8a779a0 = { > .max_height = 4096, > }; > > -static const struct rvin_info rcar_info_r8a779g0 = { > +static const struct rvin_info rcar_info_gen4 = { > .model = RCAR_GEN3, > .use_mc = true, > .use_isp = true, FTR, rcar_info_gen4 is (still) identical to rcar_info_r8a779a0. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds