On 2024-06-07 at 15:27:44, Christophe Roullier (christophe.roullier@xxxxxxxxxxx) wrote: > +static int stm32mp1_validate_ethck_rate(struct plat_stmmacenet_data *plat_dat) > +{ > + struct stm32_dwmac *dwmac = plat_dat->bsp_priv; > + const u32 clk_rate = clk_get_rate(dwmac->clk_eth_ck); nit: reverse xmas tree, split definitions and assignment.