Re: [PATCH 1/2] dt-bindings: display: panel: Add Samsung AMS639RQ08

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/06/2024 22:36, Danila Tikhonov wrote:
> The Samsung AMS639RQ08 is a 6.39 inch 1080x2340 MIPI-DSI CMD mode
> AMOLED panel used in:
> - Xiaomi Mi 9 Lite / CC9 (sdm710-xiaomi-pyxis)
> - Xiaomi Mi 9T / Redmi K20 (sm7150-xiaomi-davinci)
> - Xiaomi Mi 9T Pro / Redmi K20 Pro (sm8150-xiaomi-raphael)
> Add a dt-binding for it.
> 
> Signed-off-by: Danila Tikhonov <danila@xxxxxxxxxxx>

If there is going to be any new posting, then two changes:


> +maintainers:
> +  - Danila Tikhonov <danila@xxxxxxxxxxx>
> +  - Jens Reidel <adrian@xxxxxxxxxxxx>
> +
> +description: |

Do not need '|' unless you need to preserve formatting.

> +  The Samsung AMS639RQ08 is a 6.39 inch 1080x2340 MIPI-DSI CMD mode AMOLED panel.
> +
> +allOf:
> +  - $ref: panel-common.yaml#
> +
> +properties:
> +  compatible:
> +    const: samsung,ams639rq08
> +
> +  reg:
> +    maxItems: 1
> +
> +  vdd3p3-supply:
> +    description: 3.3V source voltage rail
> +
> +  vddio-supply:
> +    description: I/O source voltage rail
> +
> +  vsn-supply:
> +    description: Positive source voltage rail
> +
> +  vsp-supply:
> +    description: Negative source voltage rail
> +
> +  reset-gpios: true
> +  port: true
> +
> +additionalProperties: false

This goes after "required:" block.

> +
> +required:
> +  - compatible
> +  - reg
> +  - vdd3p3-supply
> +  - vddio-supply
> +  - vsn-supply
> +  - vsp-supply
> +  - reset-gpios
> +  - port
> +

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Best regards,
Krzysztof





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux