On Tue, 4 Jun 2024 15:24:31 +0200 AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx> wrote: > Il 04/06/24 15:22, Andy Shevchenko ha scritto: > > On Tue, Jun 4, 2024 at 3:30 PM AngeloGioacchino Del Regno > > <angelogioacchino.delregno@xxxxxxxxxxxxx> wrote: > >> > >> Add a driver to support reading the Auxiliary ADC IP found in the > >> MediaTek MT6357, MT6358 and MT6359 Power Management ICs, featuring > >> a different register layout, configurationm reset and ADC reading > > > > configuration > > > > Oh, oops! If there's no further comment to address, can this be fixed while > applying, please? > Yes if Rob is happy with your response to his question on the dt-binding. LGTM as well btw. Jonathan > Otherwise I can send a v3 :-) > > >> sequence from the other already supported MediaTek SoC or PMIC > >> (aux)ADC HW. > >> > >> This driver provides multiple ADC channels for system monitoring, > >> such as battery voltage, PMIC temperature, PMIC-internal voltage > >> regulators temperature, and others. > > > > Seems all my concerns were addressed, so > > Reviewed-by: Andy Shevchenko <andy@xxxxxxxxxx> > > > > Thanks! > Angelo