Hi Rob, On Fri, Jul 21, 2023 at 08:24:33AM -0600, Rob Herring wrote: > On Fri, Jul 21, 2023 at 01:03:43PM +0200, Marco Felsch wrote: > > Document the common phy-supply property to be able to specify a phy > > regulator. > > What common property? I don't see any such property in > ethernet-controller.yaml. > > > Signed-off-by: Marco Felsch <m.felsch@xxxxxxxxxxxxxx> > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > --- > > Changelog: > > v4: > > - no changes > > v3: > > - no changes > > v2 > > - add ack-by > > > > Documentation/devicetree/bindings/net/snps,dwmac.yaml | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > index ddf9522a5dc23..847ecb82b37ee 100644 > > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > @@ -160,6 +160,9 @@ properties: > > can be passive (no SW requirement), and requires that the MAC operate > > in a different mode than the PHY in order to function. > > > > + phy-supply: > > + description: PHY regulator > > Is this for an serdes, sgmii, etc. type phy or ethernet phy? Either way, > this property belongs in the PHY's node because it is the PHY that has > supply connection. I'm guessing you put this here for the latter case > because ethernet PHYs on MDIO are "discoverable" except for the small > problem that powering them on is not discoverable. Any idea on how to solve that problem generically ? -- Regards, Laurent Pinchart
