On Sat, Feb 28, 2015 at 02:10:22PM -0800, Dmitry Torokhov wrote:
> Hi Scott,
>
> On Sat, Feb 28, 2015 at 08:35:57AM -0800, Scott Branden wrote:
> > + /* Enable clock */
> > +
> > + kp->clk = devm_clk_get(&pdev->dev, "peri_clk");
> > + if (IS_ERR(kp->clk)) {
> > + dev_info(&pdev->dev,
> > + "No clock specified. Assuming it's enabled\n");
>
> I was doing the final pass before applying and I think that this is not
> quite correct, as it does not handle -EPROBE_DEFER properly which is
> quite common. I think we should do something like this:
>
> error = PTR_ERR(kp->clk);
> if (error != -ENOENT) {
> if (error != -EPROBE_DEFER)
> dev_err(.. "Failed to get clock" ...);
> return error;
> }
> dev_dbg(... "No clock specified" ...);
>
> No need to resubmit if you are OK with this, I can make the change
> locally.
Hmm, also bcm_kp_start() and bcm_kp_stop() should check if kp->clk is
valid before trying to enable/disable it.
>
> > + }
> > + else {
>
> Checkpach should have warned you that it should have been "} else {";
> I'll fix it up locally along with few other cosmetic changes and
> dropping a few extra headers.
>
> Thanks.
>
> --
> Dmitry
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
