Hi Mark Brown, Thanks for the feedc > -----Original Message----- > From: Mark Brown <broonie@xxxxxxxxxx> > Sent: Friday, June 7, 2024 4:31 PM > Subject: Re: [PATCH RFC v2 2/4] regulator: Add Renesas RZ/G2L USB VBUS regulator driver > > On Fri, Jun 07, 2024 at 12:37:43PM +0100, Biju Das wrote: > > > +static const unsigned int vbus_voltages[] = { > > + 3300000, 0 > > +}; > > + > > +static const struct regulator_ops rzg2l_usb_vbus_reg_ops = { > > + .list_voltage = regulator_list_voltage_table, }; > > This is an enable control, not a voltage set control? Yes, it is enable control(inverted logic). Disabling the bit supplies the Vbus voltage. Is there any atomic regulator API's I can make use of enabling it?? VBUS detection happens in interrupt context. Cheers, Biju