On 06/05, Conor Dooley wrote: > On Tue, Jun 04, 2024 at 07:43:53PM -0300, Marcelo Schmitt wrote: > > Add device tree documentation for AD4000 series of ADC devices. > > > > Datasheet: https://www.analog.com/media/en/technical-documentation/data-sheets/ad4000-4004-4008.pdf > > Datasheet: https://www.analog.com/media/en/technical-documentation/data-sheets/ad4001-4005.pdf > > Datasheet: https://www.analog.com/media/en/technical-documentation/data-sheets/ad4002-4006-4010.pdf > > Datasheet: https://www.analog.com/media/en/technical-documentation/data-sheets/ad4003-4007-4011.pdf > > Datasheet: https://www.analog.com/media/en/technical-documentation/data-sheets/ad4020-4021-4022.pdf > > Datasheet: https://www.analog.com/media/en/technical-documentation/data-sheets/adaq4001.pdf > > Datasheet: https://www.analog.com/media/en/technical-documentation/data-sheets/adaq4003.pdf > > > > Suggested-by: David Lechner <dlechner@xxxxxxxxxxxx> > > A suggested-by on a binding? That's unusual... > > > Signed-off-by: Marcelo Schmitt <marcelo.schmitt@xxxxxxxxxx> > > --- > > Even though didn't pick all suggestions to the dt-bindings, I did pick most them > > so kept David's Suggested-by tag. > > > > .../bindings/iio/adc/adi,ad4000.yaml | 207 ++++++++++++++++++ > > MAINTAINERS | 7 + > > 2 files changed, 214 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad4000.yaml > > > > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad4000.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad4000.yaml > > new file mode 100644 > > index 000000000000..7470d386906b > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad4000.yaml > > @@ -0,0 +1,207 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/iio/adc/adi,ad4000.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Analog Devices AD4000 and similar Analog to Digital Converters > > + > > +maintainers: > > + - Marcelo Schmitt <marcelo.schmitt@xxxxxxxxxx> > > + > > +description: | > > + Analog Devices AD4000 family of Analog to Digital Converters with SPI support. > > + Specifications can be found at: > > + https://www.analog.com/media/en/technical-documentation/data-sheets/ad4000-4004-4008.pdf > > + https://www.analog.com/media/en/technical-documentation/data-sheets/ad4001-4005.pdf > > + https://www.analog.com/media/en/technical-documentation/data-sheets/ad4002-4006-4010.pdf > > + https://www.analog.com/media/en/technical-documentation/data-sheets/ad4003-4007-4011.pdf > > + https://www.analog.com/media/en/technical-documentation/data-sheets/ad4020-4021-4022.pdf > > + https://www.analog.com/media/en/technical-documentation/data-sheets/adaq4001.pdf > > + https://www.analog.com/media/en/technical-documentation/data-sheets/adaq4003.pdf > > + > > +$ref: /schemas/spi/spi-peripheral-props.yaml# > > + > > +properties: > > + compatible: > > + enum: > > + - adi,ad4000 > > + - adi,ad4001 > > + - adi,ad4002 > > + - adi,ad4003 > > + - adi,ad4004 > > + - adi,ad4005 > > + - adi,ad4006 > > + - adi,ad4007 > > + - adi,ad4008 > > + - adi,ad4010 > > + - adi,ad4011 > > + - adi,ad4020 > > + - adi,ad4021 > > + - adi,ad4022 > > + - adi,adaq4001 > > + - adi,adaq4003 > > Are all these actually incompatible? I'd like a note in the commit > message as to why that's the case. A quick look at the driver showed > that the differences in the driver between the ad402{0,1,2} are limited > to the "dev_name". Same went for some other devices, like the > ad40{02,06,10}. Yes, that's correct. Some chips only vary by name and max sample rate which boils down to only having a different dev_name in the driver. Can those have grouped compatible strings? dt_binding_check fails if curly brackets are used. properties: compatible: enum: - adi,ad402{0,1,2} The groups of similar chips are: AD4020/AD4021/AD4022 AD4003/AD4007/AD4011 AD4002/AD4006/AD4010 AD4001/AD4005 AD4000/AD4004/AD4008 Thanks, Marcelo > > Thanks, > Conor.
