On Fri, 7 Jun 2024 at 14:38, zhaoxiong lv <lvzhaoxiong@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote: > > hi Dmitry Baryshkov > > Because this is a separate mipi dsi driver, I did not put it in > panel-sample-dsi.yaml. Driver and bindings are two separate things. Bindings describe the hardware. If there is no other reason to have a separate bindings document, please use panel-simple-dsi.yaml. Also please don't top-post in public mailing lists. > > > On Sun, Jun 2, 2024 at 12:28 AM Dmitry Baryshkov > <dmitry.baryshkov@xxxxxxxxxx> wrote: > > > > On Sat, Jun 01, 2024 at 04:45:25PM +0800, Zhaoxiong Lv wrote: > > > Create a new dt-scheam for the kd101ne3-40ti. > > > The bias IC of this kindisplay-kd101ne3 panel is placed > > > on the panel side, so when the panel is powered on, > > > there is no need to control AVDD and AVEE in the driver. > > > > > > Signed-off-by: Zhaoxiong Lv <lvzhaoxiong@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> > > > --- > > > > > > Chage since V2: > > > > > > - Drop some properties that have already been defined in panel-common. > > > - The header file 'dt-bindings/gpio/gpio.h' is not used, delete it > > > > > > V1: https://lore.kernel.org/all/20240418081548.12160-2-lvzhaoxiong@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/ > > > > > > --- > > > .../panel/kingdisplay,kd101ne3-40ti.yaml | 59 +++++++++++++++++++ > > > 1 file changed, 59 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/display/panel/kingdisplay,kd101ne3-40ti.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/display/panel/kingdisplay,kd101ne3-40ti.yaml b/Documentation/devicetree/bindings/display/panel/kingdisplay,kd101ne3-40ti.yaml > > > new file mode 100644 > > > index 000000000000..b0cf12bb727d > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/display/panel/kingdisplay,kd101ne3-40ti.yaml > > > @@ -0,0 +1,59 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/display/panel/kingdisplay,kd101ne3-40ti.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Kingdisplay KD101NE3-40TI based MIPI-DSI panels > > > + > > > +maintainers: > > > + - Zhaoxiong Lv <lvzhaoxiong@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> > > > > Any reason for using a separate bindings instead of extending > > panel-simple-dsi.yaml ? > > > > > + > > > +allOf: > > > + - $ref: panel-common.yaml# > > > + > > > +properties: > > > + compatible: > > > + items: > > > + - enum: > > > + - kingdisplay,kd101ne3-40ti > > > + > > > + reg: > > > + description: the virtual channel number of a DSI peripheral > > > + > > > + pp3300-supply: > > > + description: core voltage supply > > > + > > > +required: > > > + - compatible > > > + - reg > > > + - pp3300-supply > > > + - enable-gpios > > > + - backlight > > > + - port > > > + > > > +unevaluatedProperties: false > > > + > > > +examples: > > > + - | > > > + dsi { > > > + #address-cells = <1>; > > > + #size-cells = <0>; > > > + panel: panel@0 { > > > + compatible = "kingdisplay,kd101ne3-40ti"; > > > + reg = <0>; > > > + enable-gpios = <&pio 98 0>; > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&panel_pins_default>; > > > + pp3300-supply = <&en_pp6000_mipi_disp>; > > > + backlight = <&backlight_lcd0>; > > > + rotation = <90>; > > > + port { > > > + panel_in: endpoint { > > > + remote-endpoint = <&dsi_out>; > > > + }; > > > + }; > > > + }; > > > + }; > > > + > > > +... > > > -- > > > 2.17.1 > > > > > > > -- > > With best wishes > > Dmitry -- With best wishes Dmitry
