On Thu, Jun 06, 2024 at 10:52:25AM +0200, Martin Schiller wrote: > From: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx> > > We don't need to manually call gswip_port_enable() from within > gswip_setup() for the CPU port. DSA does this automatically for us. > > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx> > --- Not to mention the first thing in gswip_port_enable(), which is: if (!dsa_is_user_port(ds, port)) return 0; So the call is dead code anyway.