Re: [PATCH v6 3/9] iio: adc: ad_sigma_delta: add disable_one callback

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/06/2024 12:02, Nuno Sá wrote:
> On Thu, 2024-06-06 at 19:07 +0300, Dumitru Ceclan via B4 Relay wrote:
>> From: Dumitru Ceclan <dumitru.ceclan@xxxxxxxxxx>
>>
>> Sigma delta ADCs with a sequencer need to disable the previously enabled
>> channel when reading using ad_sigma_delta_single_conversion(). This was
>> done manually in drivers for devices with sequencers.
>>
>> This patch implements handling of single channel disabling after a
>> single conversion.
>>
>> Signed-off-by: Dumitru Ceclan <dumitru.ceclan@xxxxxxxxxx>
>> ---
> 
> You could have this done in separate patches... Oh well, this is simple enough
> that I don't care much.
> 
> Reviewed-by: Nuno Sa <nuno.sa@xxxxxxxxxx>
> 

Separate patches would break driver functionality then fix it.
The drivers would not probe as disable_one() callback is missing.

This would have been alright?





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux