On 05/06/2024 10:19, Andreas Kemnade wrote: > Convert the regulator bindings to yaml files. To allow only the regulator > compatible corresponding to the toplevel mfd compatible, split the file > into one per device. > > Drop one twl5030 compatible due to no documentation on mfd side and no > users of the twl5030. > > Signed-off-by: Andreas Kemnade <andreas@xxxxxxxxxxxx> > --- > Changes in v3: > - define regulator stuff in toplevel > - simplified regulator-inital-mode > - extended example to contain both regulator-initial-mode and > retain-on-reset > > Changes in v2: > - add regulators directly to ti,twl.yaml > - less restrictions on regulator node name Thank you for your patch. There is something to discuss/improve. > + > properties: > gpadc: > type: object > @@ -69,6 +116,26 @@ allOf: > contains: > const: ti,twl6032 > then: > + patternProperties: > + "^regulator-": > + unevaluatedProperties: false Drop, looks odd here. > + properties: > + compatible: > + enum: > + - ti,twl6032-ldo1 > + - ti,twl6032-ldo2 > + - ti,twl6032-ldo3 > + - ti,twl6032-ldo4 > + - ti,twl6032-ldo5 > + - ti,twl6032-ldo6 > + - ti,twl6032-ldo7 > + - ti,twl6032-ldoln > + - ti,twl6032-ldousb > + - ti,twl6032-smps3 with that: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Best regards, Krzysztof
