On Wed, Jun 05, 2024 at 11:58:28AM GMT, Tomasz Jeznach wrote: > On Wed, May 29, 2024 at 8:15 AM Andrew Jones <ajones@xxxxxxxxxxxxxxxx> wrote: ... > > > +/* 3.1.3 I/O MMU Directory cache invalidation */ > > > +/* Fields on dword0 */ > > > +#define RISCV_IOMMU_CMD_IODIR_OPCODE 3 > > > +#define RISCV_IOMMU_CMD_IODIR_FUNC_INVAL_DDT 0 > > > +#define RISCV_IOMMU_CMD_IODIR_FUNC_INVAL_PDT 1 > > > +#define RISCV_IOMMU_CMD_IODIR_PID GENMASK_ULL(31, 12) > > > +#define RISCV_IOMMU_CMD_IODIR_DV BIT_ULL(33) > > > +#define RISCV_IOMMU_CMD_IODIR_DID GENMASK_ULL(63, 40) > > > > RISCV_IOMMU_CMD_IOTDIR_* for all above > > > > I've checked latest RISC-V IOMMU Arch Specification and it looks there > it is a bit inconsistent in IODIR naming. The acronym IOTDIR is used > only once, while all other references to directory cache invalidation > command use IODIR. I'll keep _CMD_IODIR_ here. > Indeed. I've made a comment on the spec clarifications PR to suggest the s/IOTDIR/IODIR/ change. Thanks, drew
