On 06/06/2024 03:08, Daisuke Nojiri wrote: > Add support for keyboard matrix version 3.0. Not much improved. > > Signed-off-by: Daisuke Nojiri <dnojiri@xxxxxxxxxxxx> This is a friendly reminder during the review process. It seems my or other reviewer's previous comments were not fully addressed. Maybe the feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them. Do not attach (thread) your patchsets to some other threads (unrelated or older versions). This buries them deep in the mailbox and might interfere with applying entire sets. Best regards, Krzysztof