On Sun, Jun 02, 2024 at 05:36:21PM +0300, Serge Semin wrote:
...
> diff --git a/drivers/net/pcs/pcs-xpcs-plat.c b/drivers/net/pcs/pcs-xpcs-plat.c
...
> +const struct dev_pm_ops xpcs_plat_pm_ops = {
> + SET_RUNTIME_PM_OPS(xpcs_plat_pm_runtime_suspend,
> + xpcs_plat_pm_runtime_resume,
> + NULL)
> +};
nit: xpcs_plat_pm_ops only seems to be used in this file.
If so it should probably be static.
Flagged by Sparse.
...
> +static struct platform_driver xpcs_plat_driver = {
> + .probe = xpcs_plat_probe,
> + .driver = {
> + .name = "dwxpcs",
> + .pm = &xpcs_plat_pm_ops,
> + .of_match_table = xpcs_of_ids,
> + },
> +};
> +module_platform_driver(xpcs_plat_driver);
...
