Re: [PATCH 1/2] dt-bindings: display: bridge: tc358867: Document default DP preemphasis

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/5/24 6:03 PM, Rob Herring wrote:

Hi,

diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358767.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358767.yaml
index 2ad0cd6dd49e0..dcf56e996ee22 100644
--- a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358767.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358767.yaml
@@ -98,6 +98,24 @@ properties:
              reference to a valid eDP panel input endpoint node. This port is
              optional, treated as DP panel if not defined
+ properties:
+          endpoint:
+            $ref: /schemas/media/video-interfaces.yaml#
+            unevaluatedProperties: false
+
+            properties:
+              toshiba,pre-emphasis:

You didn't test adding this property. You will find it isn't allowed.
That's because 'properties/port' schema above doesn't allow extra
properties (on the port and endpoint).

Fixed

+                description:
+                  Display port output Pre-Emphasis settings for both ports.

Both ports? This schema is for just port 2.

'lanes' is better here. The array can be used to configure each DP main link lane separately, the chip supports two lanes.




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux