Re: [PATCH v2 01/16] dt-bindings: clock: qcom,sm8450-videocc: reference qcom,gcc.yaml

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Krzysztof Kozlowski (2024-06-05 01:09:28)
> diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml
> index bad8f019a8d3..74034e3f79b7 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml
> @@ -39,26 +36,17 @@ properties:
>      description:
>        A phandle to an OPP node describing required MMCX performance point.
>  
> -  '#clock-cells':
> -    const: 1
> -
> -  '#reset-cells':
> -    const: 1
> -
> -  '#power-domain-cells':
> -    const: 1
> -
>  required:
>    - compatible
> -  - reg
>    - clocks
>    - power-domains
>    - required-opps
> -  - '#clock-cells'
> -  - '#reset-cells'
>    - '#power-domain-cells'

Missed removing this one?

>  
> -additionalProperties: false
> +allOf:
> +  - $ref: qcom,gcc.yaml#

Why not have a one-cell-clock-reset-power-domain.yaml binding that
combines all these things? It's quite common even outside of qcom.





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux