Re: [PATCH 0/3] Add ktd2692 Flash LED driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hi Ingi,

On 02/27/2015 02:01 AM, Ingi Kim wrote:
This patch supports KTD2692 flash LED driver

Ingi Kim (3):
   of: Add vendor prefix for Kinetic technologies
   leds: ktd2692: add device tree bindings for ktd2692
   leds: Add ktd2692 flash LED driver

  .../devicetree/bindings/leds/leds-ktd2692.txt      |   19 ++
  .../devicetree/bindings/vendor-prefixes.txt        |    1 +
  drivers/leds/Kconfig                               |    8 +
  drivers/leds/Makefile                              |    1 +
  drivers/leds/leds-ktd2692.c                        |  245 ++++++++++++++++++++
  5 files changed, 274 insertions(+)
  create mode 100644 Documentation/devicetree/bindings/leds/leds-ktd2692.txt
  create mode 100644 drivers/leds/leds-ktd2692.c


In your device tree binding documentation there is torch-gpio mentioned,
but you seem not to use it in the driver.

We have already LED Flash class (/drivers/leds/led-class-flash.c) for
this type of devices, which handles both torch and flash modes
(flash_strobe sysfs attribute is provided for strobing the flash).

The reference drivers using LED Flash class are still pending [1], but I
think that at least leds-aat1290 driver is almost ready for merging.
It controls very similar device to yours.

Another advantage of using LED Flash class is that it has been designed
to be compatible with Video for Linux 2 subsystem, which will allow for registering LED Flash class devices as a V4L2 sub-devices.

Adding Sakari.

--
Best Regards,
Jacek Anaszewski

[1] http://www.spinics.net/lists/linux-media/msg86632.html
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux