Hi Daisuke, On Tue, Jun 04, 2024 at 10:09:33AM -0700, Daisuke Nojiri wrote: > Add support for keyboard matrix version 3.0. To enable it, define > CONFIG_CROS_KBD_V30. I might be wrong but it looks to me if one enables support for v3 keymap then the kernel will not work for devices using other/older versions of keymap. It might be acceptable for Chrome OS kernels but will nto work for upstream. I think you need to create arch/arm/boot/dts/cros-ec-keyboard-v3.dtsi that would define "keyboard_controller" node with proper keymap and include this new dtsi into std files for devices/boards that need it. Thanks. -- Dmitry