Re: [PATCH 1/2] dt-bindings: display: bridge: tc358867: Document default DP preemphasis

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/4/24 11:42 AM, Alexander Stein wrote:
Hi Marek,

Hi,

--- a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358767.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358767.yaml
@@ -98,6 +98,24 @@ properties:
              reference to a valid eDP panel input endpoint node. This port is
              optional, treated as DP panel if not defined
+ properties:
+          endpoint:
+            $ref: /schemas/media/video-interfaces.yaml#
+            unevaluatedProperties: false
+
+            properties:
+              toshiba,pre-emphasis:
+                description:
+                  Display port output Pre-Emphasis settings for both ports.

Is this a property of the port or the endpoint?

Endpoint I think.

+                $ref: /schemas/types.yaml#/definitions/uint32-array
+                minItems: 2
+                maxItems: 2
+                items:
+                  enum:
+                    - 0 # -6dB de-emphasis
+                    - 1 # -3.5dB de-emphasis
+                    - 2 # No de-emphasis

Is there a reason you reversed the notation here? de-emphasis <-> pre-emphasis.
Commit message also says:
in range 0=0dB, 1=3.5dB, 2=6dB .

Copy-paste error from Documentation/devicetree/bindings/usb/snps,dwc3.yaml , fixed in V2, thanks .




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux