On Wed, May 29, 2024 at 06:29:55PM +0200, Johan Hovold wrote: > Rework the pm8008 binding by dropping internal details like register > offsets and interrupts and by adding the missing regulator and > temperature alarm properties. > > Note that child nodes are still used for pinctrl and regulator > configuration. > > Also note that the pinctrl state definition will be extended later and > could eventually also be shared with other PMICs (e.g. by breaking out > bits of qcom,pmic-gpio.yaml). This commit message should also state there are no users. > > Signed-off-by: Johan Hovold <johan+linaro@xxxxxxxxxx> > --- > .../devicetree/bindings/mfd/qcom,pm8008.yaml | 149 +++++++++++------- > 1 file changed, 90 insertions(+), 59 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml b/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml > index d71657f488db..ccf472e7f552 100644 > --- a/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml > +++ b/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml > @@ -27,103 +27,134 @@ properties: > reset-gpios: > maxItems: 1 > > - "#interrupt-cells": > + vdd-l1-l2-supply: true > + vdd-l3-l4-supply: true > + vdd-l5-supply: true > + vdd-l6-supply: true > + vdd-l7-supply: true > + > + gpio-controller: true > + > + "#gpio-cells": > const: 2 > > - description: | > - The first cell is the IRQ number, the second cell is the IRQ trigger > - flag. All interrupts are listed in include/dt-bindings/mfd/qcom-pm8008.h. > + gpio-ranges: > + maxItems: 1 > > interrupt-controller: true > > - "#address-cells": > - const: 1 > + "#interrupt-cells": > + const: 2 > > - "#size-cells": > + "#thermal-sensor-cells": > const: 0 > > -patternProperties: > - "^gpio@[0-9a-f]+$": > + pinctrl: > type: object > + additionalProperties: false > + patternProperties: > + "-state$": > + type: object > + $ref: "#/$defs/qcom-pm8008-pinctrl-state" There's only 1 reference to this, so just move the $def contents here. Rob
