On Thu, Feb 26, 2015 at 10:14 AM, Mathieu Poirier <mathieu.poirier@xxxxxxxxxx> wrote: > The System Trace Macrocell (STM) is an IP block falling under the > CoreSight umbrella. It's main purpose it so expose stimulus channels > to any system component for the purpose of information logging. > > Bindings for this IP block adds a couple of items to the current > mandatory definition for CoreSight components. The driver has been posted > here[1]. > > [1]. https://lkml.org/lkml/2015/2/25/743 > > Signed-off-by: Mathieu Poirier <mathieu.poirier@xxxxxxxxxx> Seems reasonable, but a couple minor comments below. Merge this with the driver: Acked-by: Rob Herring <robh@xxxxxxxxxx> > --- > .../devicetree/bindings/arm/coresight.txt | 25 ++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/coresight.txt b/Documentation/devicetree/bindings/arm/coresight.txt > index a3089359aaa6..854127578718 100644 > --- a/Documentation/devicetree/bindings/arm/coresight.txt > +++ b/Documentation/devicetree/bindings/arm/coresight.txt > @@ -17,6 +17,7 @@ its hardware characteristcs. > - "arm,coresight-tmc", "arm,primecell"; > - "arm,coresight-funnel", "arm,primecell"; > - "arm,coresight-etm3x", "arm,primecell"; > + - "arm,coresight-stm", "arm,primecell"; No versions of STM? > * reg: physical base address and length of the register > set(s) of the component. > @@ -31,6 +32,14 @@ its hardware characteristcs. > layout using the generic DT graph presentation found in > "bindings/graph.txt". > > +* Additional required properly for System Trace Macrocells (STM): > + * reg: along with the physical base address and length of the register > + set as described above, another entry is required to describe the > + mapping of the extended stimulus port area. > + > + * reg-names: the only acceptable values are "stm-base" and > + "stm-channel-base", each corresponding to the areas defined in "reg". It is not really clear that "extended stimulus port area" corresponds to "stm-channel-base". > + > * Required properties for devices that don't show up on the AMBA bus, such as > non-configurable replicators: > > @@ -198,3 +207,19 @@ Example: > }; > }; > }; > + > +4. STM > + stm@20100000 { > + compatible = "arm,coresight-stm", "arm,primecell"; > + reg = <0 0x20100000 0 0x1000>, > + <0 0x28000000 0 0x180000>; > + reg-names = "stm-base", "stm-channel-base"; > + > + clocks = <&soc_smc50mhz>; > + clock-names = "apb_pclk"; > + port { > + stm_out_port: endpoint { > + remote-endpoint = <&main_funnel_in_port2>; > + }; > + }; > + }; > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
