On Mon, May 27, 2024 at 05:13:39PM +0200, Krzysztof Kozlowski wrote: > On 27/05/2024 16:45, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx> > > > > There's a set of compatibles for which we set a strict list of 5 interrupt > > names even though minItems for the interrupts property is 4. One of the > > USB controllers on sa8775p only consumes 4 interrupts which leads to > > dtbs_check errors. Make the last entry optional by setting minItems to 4. > > > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx> > > --- > > Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 1 + > > 1 file changed, 1 insertion(+) > > Can you also fix other cases? I found there at least two other. I missed > that during review... or maybe we discussed it? I remember that commit > was a pain :/ Yes, please make sure to fix those two remaining instances at the same time. > But be sure that this is what we actually want. Maybe intention was to > have fixed number of interrupts (so no minItems in interrupts)? I'm pretty sure the intention was to keep the SuperSpeed interrupts optional. Johan
