Hi Niklas, On Mon, May 27, 2024 at 3:41 PM Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> wrote: > Before adding the CSI nodes for gray-hawk create a dedicated DTS file > for the CSI/DSI functionality to reflect what is done for white-hawk. > > For now its contents are limited to the Board ID EEPROM. > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> Thanks for your patch > --- /dev/null > +++ b/arch/arm64/boot/dts/renesas/gray-hawk-csi-dsi.dtsi > @@ -0,0 +1,16 @@ > +// SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +/* > + * Device Tree Source for the R-Car V4M Gray Hawk CSI/DSI sub-board I have mixed feelings about this patch, as (AFAIK) there is no such thing as a Gray Hawk CSI/DSI sub-board, so at least the comment should be fixed. However, it does make sense to make things as similar as possible to White Hawk (Single). In the end, I do hope to share most of the White/Gray Hawk (Single) DTS. Of course we have to cater for the small differences like the use of a C-PHY vs. D-PHY, which is one difference I hadn't realized before. What do other people think? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds