On Sun, Feb 22, 2015 at 11:54 PM, Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx> wrote: > This patch adds rpm node to apq8064 dt as rpm would be used by other > devices for regulator support. Also adds all the regulators in the rpm. > This looks good, with Kumars suggestion of GIT defines Reviewed-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxxxxxx> However, this binding is not merged yet and Stephen have requesting a complete redesign of the binding as well as the code. So that has to be concluded first, I presume. Separate of that, as it's highly likely that everyone will follow the pcb design guidelines for apq8064 the vin-supplies should be okay to specify at this level (and not in all board files). Perhaps also the switching frequencies for the SMPSs? Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html