On Mon, Jun 03, 2024 at 01:21:33PM +0200, Noralf Trønnes via B4 Relay wrote: > From: Noralf Trønnes <noralf@xxxxxxxxxxx> > > mipi_dbi_machine_little_endian() should really have been called > mipi_dbi_framebuffer_little_endian() because that's the function it > performs. When I added support for these SPI displays I thought that the > framebuffers on big endian machines were also big endian, but I have > later learned that this is not the case. There's a bit in the fourcc code > that controls this: DRM_FORMAT_BIG_ENDIAN. > > Just remove the function to avoid confusion. We can add big endian support > later should the need arise and we have hardware to test on. > > Instead of just amending the docs, expand it to explain the endianness > handling. > > Signed-off-by: Noralf Trønnes <noralf@xxxxxxxxxxx> > --- > drivers/gpu/drm/drm_mipi_dbi.c | 35 +++++++++++++++++++---------------- > 1 file changed, 19 insertions(+), 16 deletions(-) > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> -- With best wishes Dmitry
