On Sun, Jun 02, 2024 at 05:56:24PM +0300, Abel Vesa wrote: > The CRD board doesn't have the 4th SMB2360 PMIC populated while the QCP > does. So enabled it on QCP only. s/enabled/enable/ With that in place: Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> foo-pmics.dtsi definitely is not the best solution, but it seems to be a lesser evil. > > Fixes: 2559e61e7ef4 ("arm64: dts: qcom: x1e80100-pmics: Add the missing PMICs") > Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxx> > --- > arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi | 2 ++ > arch/arm64/boot/dts/qcom/x1e80100-qcp.dts | 4 ++++ > 2 files changed, 6 insertions(+) > -- With best wishes Dmitry