Hi Krzysztof, On Sun, Jun 02, 2024 at 05:31:04PM +0200, Krzysztof Kozlowski wrote: > On 02/06/2024 17:24, Laurent Pinchart wrote: > > The ADP5585 is a 10/11 input/output port expander with a built in keypad > > matrix decoder, programmable logic, reset generator, and PWM generator. > > These bindings model the device as an MFD, and support the GPIO expander > > and PWM functions. > > Please use subject prefixes matching the subsystem, e.g. dt-bindings: mfd: > > A nit, subject: drop second/last, redundant "bindings for". The > "dt-bindings" prefix is already stating that these are bindings. > See also: > https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18 I'll do that. It would be nice if someone could teach checkpatch about this rule. > > These bindings support the GPIO and PWM functions. > > > > Drop the existing adi,adp5585 and adi,adp5585-02 compatible strings from > > trivial-devices.yaml. They have been added there by mistake as the > > driver that was submitted at the same time used different compatible > > strings. We can take them over safely. > > > > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + i2c { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + mfd@34 { > > mfd is Linuxism, so this should be probably "io-expander" or something > similar. Sure. > > + compatible = "adi,adp5585-00", "adi,adp5585"; > > + reg = <0x34>; > > + > > + vdd-supply = <®_3v3>; > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> -- Regards, Laurent Pinchart
