On Fri, May 31, 2024 at 01:37:01PM GMT, Haylen Chu wrote: > Sorry, I forgot add cc and to in the last email. This is a resend. > > On Fri, May 31, 2024 at 07:45:37AM +0800, Inochi Amaoto wrote: > > The sensors of CV1800 support various periods, I think you should add > > support for all of them and let user select them. The configuration > > you use now can be left as the default. > > I will make sample period configurable in next revision. > > > > +{ > > > + return ((result * 1000) * 716 / 2048 - 273000); > > > +} > > > > Why these magic number, I have not see any info in the document. > > Actually, there is no document of calculating real temperature from raw > register value. The equation above is extracted from code provided by > Sophgo. > > I have figured out meaning of part of the equation and could add some > comments to document it. > I think you misunderstood. I did not only ask for the document, but also a formula that respects the configuration. It is pretty weird to use all fix magic number to calculate the temp value since the sensors itself supports various configuration, right?