On Fri, May 31, 2024 at 03:52:18PM +0200, Krzysztof Kozlowski wrote: > Hi, > > Unify Qualcomm clock controllers by referencing qcom,gcc.yaml where > applicable. Several existing bindings for these display/GPU/CAM clock > controllers already do it. The series looks good to me with a single point in mind. You are writing that dispcc/videocc/etc are a variant of GCC. However GCC is a Global Clock Controller. What about renaming qcom,gcc.yaml to qcom,cc-common.yaml ? Then the rest makes total sense to me. > > No external dependencies, this CAN be applied independently, but require > power-domain-cells in each binding, just like Dmitry's new set is doing. > > https://lore.kernel.org/all/20240529-qcom-gdscs-v2-0-69c63d0ae1e7@xxxxxxxxxx/ > > Best regards, > Krzysztof > > --- > Krzysztof Kozlowski (16): > dt-bindings: clock: qcom,sm8450-videocc: reference qcom,gcc.yaml > dt-bindings: clock: qcom,videocc: reference qcom,gcc.yaml > dt-bindings: clock: qcom,dispcc-sc8280xp: reference qcom,gcc.yaml > dt-bindings: clock: qcom,dispcc-sm6350: reference qcom,gcc.yaml > dt-bindings: clock: qcom,dispcc-sm8x50: reference qcom,gcc.yaml > dt-bindings: clock: qcom,gpucc-sdm660: reference qcom,gcc.yaml > dt-bindings: clock: qcom,gpucc: reference qcom,gcc.yaml > dt-bindings: clock: qcom,msm8998-gpucc: reference qcom,gcc.yaml > dt-bindings: clock: qcom,qcm2290-dispcc: reference qcom,gcc.yaml > dt-bindings: clock: qcom,sc7180-dispcc: reference qcom,gcc.yaml > dt-bindings: clock: qcom,sc7280-dispcc: reference qcom,gcc.yaml > dt-bindings: clock: qcom,sdm845-dispcc: reference qcom,gcc.yaml > dt-bindings: clock: qcom,sm6115-dispcc: reference qcom,gcc.yaml > dt-bindings: clock: qcom,sm8450-dispcc: reference qcom,gcc.yaml > dt-bindings: clock: qcom,sm8550-dispcc: reference qcom,gcc.yaml > dt-bindings: clock: qcom,sm8450-gpucc: reference qcom,gcc.yaml > > .../bindings/clock/qcom,dispcc-sc8280xp.yaml | 20 ++++---------------- > .../bindings/clock/qcom,dispcc-sm6350.yaml | 20 ++++---------------- > .../bindings/clock/qcom,dispcc-sm8x50.yaml | 18 ++---------------- > .../devicetree/bindings/clock/qcom,gpucc-sdm660.yaml | 20 ++++---------------- > .../devicetree/bindings/clock/qcom,gpucc.yaml | 20 ++++---------------- > .../bindings/clock/qcom,msm8998-gpucc.yaml | 20 ++++---------------- > .../bindings/clock/qcom,qcm2290-dispcc.yaml | 20 ++++---------------- > .../bindings/clock/qcom,sc7180-dispcc.yaml | 20 ++++---------------- > .../bindings/clock/qcom,sc7280-dispcc.yaml | 20 ++++---------------- > .../bindings/clock/qcom,sdm845-dispcc.yaml | 20 ++++---------------- > .../bindings/clock/qcom,sm6115-dispcc.yaml | 20 ++++---------------- > .../bindings/clock/qcom,sm8450-dispcc.yaml | 20 ++++---------------- > .../devicetree/bindings/clock/qcom,sm8450-gpucc.yaml | 20 ++++---------------- > .../bindings/clock/qcom,sm8450-videocc.yaml | 20 ++++---------------- > .../bindings/clock/qcom,sm8550-dispcc.yaml | 20 ++++---------------- > .../devicetree/bindings/clock/qcom,videocc.yaml | 19 +++---------------- > 16 files changed, 61 insertions(+), 256 deletions(-) > --- > base-commit: b0afb900b7d235d879f8e8e4babfe77d9db76f2f > change-id: 20240531-dt-bindings-qcom-gcc-e2955fd60004 > > Best regards, > -- > Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > -- With best wishes Dmitry
