On Fri, May 31, 2024 at 03:51:56PM +0100, Conor Dooley wrote: > On Fri, May 31, 2024 at 04:35:52PM +0300, Ramona Alexandra Nechita wrote: > > Add dt bindings for adc ad7779. > > > > Signed-off-by: Ramona Alexandra Nechita <ramona.nechita@xxxxxxxxxx> > > --- > > .../ABI/testing/sysfs-bus-iio-adc-ad777x | 23 +++++ > > .../bindings/iio/adc/adi,ad7779.yaml | 87 +++++++++++++++++++ > > 2 files changed, 110 insertions(+) > > create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-adc-ad777x > > create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7779.yaml > > > > diff --git a/Documentation/ABI/testing/sysfs-bus-iio-adc-ad777x b/Documentation/ABI/testing/sysfs-bus-iio-adc-ad777x > > new file mode 100644 > > index 000000000000..0a57fda598e6 > > --- /dev/null > > +++ b/Documentation/ABI/testing/sysfs-bus-iio-adc-ad777x > > @@ -0,0 +1,23 @@ > > +What: /sys/bus/iio/devices/iio:deviceX/filter_type_available > > +KernelVersion: 6.1 > > +Contact: linux-iio@xxxxxxxxxxxxxxx > > +Description: > > + Reading returns a list with the possible filter modes. Only supported by > > + AD7771. > > + > > + * "sinc3" - The digital sinc3 filter implements three main notches, one at > > + the maximum ODR (128 kHz or 32 kHz, depending on the > > + power mode) and another two at the ODR frequency selected to > > + stop noise aliasing into the pass band. > > + > > + * "sinc5" - The sinc5 filter implements five notches, one at > > + the maximum ODR (128 kHz or 32 kHz, depending on the > > + power mode) and another four at the ODR frequency > > + selected to stop noise aliasing into the pass band. > > + > > +What: /sys/bus/iio/devices/iio:deviceX/filter_type > > +KernelVersion: 6.1 > > +Contact: linux-iio@xxxxxxxxxxxxxxx > > +Description: > > + Set the filter mode of the differential channel. The current sampling_frequency > > + is set according to the filter range. Only supported by AD7771. > > This patch is really confusing to me. Why is there a file documenting > the sysfs interface for a driver that isn't in the tree? Shouldn't this > patch be part of a series that adds the driver? I suggest you speak to > Nuno or another collogue about how to submit a series. Colleague*, auto accepting vim's first spelling suggestion strikes again :)
Attachment:
signature.asc
Description: PGP signature
