Re: [RFC PATCH] arm64: dts: rockchip: Make preparations for per-RK3588-variant OPPs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2024-05-29 13:33, Dragan Simic wrote:
On 2024-05-29 13:09, Diederik de Haas wrote:
On Wednesday, 29 May 2024 11:57:45 CEST Alexey Charkov wrote:

[...]

>  arch/arm64/boot/dts/rockchip/rk3588.dtsi      |  414 +--
>  arch/arm64/boot/dts/rockchip/rk3588j.dtsi     |    6 +-
>  arch/arm64/boot/dts/rockchip/rk3588s.dtsi     | 2671 +----------------

Rename detection didn't do a particularly great job here - wonder if
we can do anything about it to minimize the patch size and ensure that
the change history is preserved for git blame...

+1
The diff does look awfully big for a rename operation, which was supposed to
(also only) "modify ... a bit".

I also don't like the size of the patch.  I just tried playing with
specifying different values for the --find-renames and --find-copies
options, but with no good results.  I'll have a look into the Git
source later, to see what's actually going on with those options.

Yay, --break-rewrites makes the diff extremely compact. :) [1]

[1] https://git-scm.com/docs/git-diff#Documentation/git-diff.txt--Bltngtltmgt




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux