Re: [PATCH 2/3] hwmon: Add support for SPD5118 compliant temperature sensors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 5/30/24 06:57, Thomas Weißschuh wrote:
On 2024-05-30 06:47:17+0000, Guenter Roeck wrote:
On 5/30/24 03:51, Thomas Weißschuh wrote:
On 2024-05-29 13:52:03+0000, Guenter Roeck wrote:
Add support for SPD5118 (Jedec JESD300-5B.01) compliant temperature
sensors. Such sensors are typically found on DDR5 memory modules.

Cc: René Rebe <rene@xxxxxxxxxxxx>
Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
---
Tested on MAG B650 TOMAHAWK WIFI with CMH32GX5M2B6000Z30
(Corsair Venegance DDR5).

René: I included you as MODULE_AUTHOR since the patch is derived from
        your driver. Please let me know if you prefer not to be listed as
        author.

   Documentation/hwmon/index.rst   |   1 +
   Documentation/hwmon/spd5118.rst |  60 ++++
   drivers/hwmon/Kconfig           |  12 +
   drivers/hwmon/Makefile          |   1 +
   drivers/hwmon/spd5118.c         | 482 ++++++++++++++++++++++++++++++++
   5 files changed, 556 insertions(+)
   create mode 100644 Documentation/hwmon/spd5118.rst
   create mode 100644 drivers/hwmon/spd5118.c

With the Makefile and detect callback fixed:

Reviewed-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx>
Tested-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx>

Thanks a lot for the feedback!

If it is not too much trouble, could you send me a register dump ?
The one I have is from Montage Technology M88SPD5118, and I'd like to get
a few more to improve my module test script.

From a Kingston KF556S40-32:

# i2cdump 20 0x50
      0  1  2  3  4  5  6  7  8  9  a  b  c  d  e  f    0123456789abcdef
00: 51 18 0a 86 32 03 32 00 00 00 00 07 ff 3c 00 00    Q???2?2....?.<..
10: 00 00 00 00 00 00 00 00 00 00 00 00 70 03 00 00    ............p?..
20: 50 05 00 00 00 00 00 00 00 00 00 00 00 00 00 00    P?..............
30: 00 f0 01 00 00 00 00 00 00 00 00 00 00 00 00 00    .??.............
40: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
50: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
60: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
70: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
90: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
c0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
d0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
e0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
f0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................

This is the same SPD hub chip (Montage Technology M88SPD5118)
as used on my Corsair DDRs. Interesting.

Thanks!
Guenter





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux