On Wed, May 29, 2024 at 10:53:09PM +0300, Andy Shevchenko wrote: > On Wed, May 29, 2024 at 7:30 PM Johan Hovold <johan+linaro@xxxxxxxxxx> wrote: > > + ret = devm_regmap_add_irq_chip_fwnode(dev, fwnode, regmap, client->irq, > > IRQF_SHARED, 0, &pm8008_irq_chip, &irq_data); > > + if (ret) { > > + dev_err(dev, "failed to add IRQ chip: %d\n", ret); > > + return ret; > > } > > I believe there is no harm to use > > return dev_err_probe(...); > > for these. But it seems you don't like that API. Whatever, no-one will > die, just additional work for the future :-) Correct. And there's no additional work for the future here either. Johan