Hi Dan, Thank you for the patch. On Wed, May 29, 2024 at 04:28:44PM +0100, Daniel Scally wrote: > The Mali-C55 requires input data be in 20-bit format, MSB aligned. > Add some new media bus format macros to represent that input format. > > Co-developed-by: Jacopo Mondi <jacopo.mondi@xxxxxxxxxxxxxxxx> > Signed-off-by: Jacopo Mondi <jacopo.mondi@xxxxxxxxxxxxxxxx> > Signed-off-by: Daniel Scally <dan.scally@xxxxxxxxxxxxxxxx> > --- > Changes in v5: > > - New patch > > .../media/v4l/subdev-formats.rst | 100 ++++++++++++++++++ > include/uapi/linux/media-bus-format.h | 6 +- > 2 files changed, 105 insertions(+), 1 deletion(-) > > diff --git a/Documentation/userspace-api/media/v4l/subdev-formats.rst b/Documentation/userspace-api/media/v4l/subdev-formats.rst > index 8d164a9a9e15..f986dfc52879 100644 > --- a/Documentation/userspace-api/media/v4l/subdev-formats.rst > +++ b/Documentation/userspace-api/media/v4l/subdev-formats.rst > @@ -3445,6 +3445,106 @@ organization is given as an example for the first pixel only. > - r\ :sub:`2` > - r\ :sub:`1` > - r\ :sub:`0` > + * .. _MEDIA-BUS-FMT-SBGGR20-1X20: > + > + - MEDIA_BUS_FMT_SBGGR20_1X20 > + - 0x3021 > + - > + - r\ :sub:`19` > + - r\ :sub:`18` > + - r\ :sub:`17` > + - r\ :sub:`16` > + - r\ :sub:`15` > + - r\ :sub:`14` > + - r\ :sub:`13` > + - r\ :sub:`12` > + - r\ :sub:`11` > + - r\ :sub:`10` > + - r\ :sub:`9` > + - r\ :sub:`8` > + - r\ :sub:`7` > + - r\ :sub:`6` > + - r\ :sub:`5` > + - r\ :sub:`4` > + - r\ :sub:`3` > + - r\ :sub:`2` > + - r\ :sub:`1` > + - r\ :sub:`0` The table currently has 16 columns for data bits. You need to expand that to 20 columns. > + * .. _MEDIA-BUS-FMT-SGBRG20-1X20: > + > + - MEDIA_BUS_FMT_SGBRG20_1X20 > + - 0x3022 > + - > + - r\ :sub:`19` > + - r\ :sub:`18` > + - r\ :sub:`17` > + - r\ :sub:`16` > + - r\ :sub:`15` > + - r\ :sub:`14` > + - r\ :sub:`13` > + - r\ :sub:`12` > + - r\ :sub:`11` > + - r\ :sub:`10` > + - r\ :sub:`9` > + - r\ :sub:`8` > + - r\ :sub:`7` > + - r\ :sub:`6` > + - r\ :sub:`5` > + - r\ :sub:`4` > + - r\ :sub:`3` > + - r\ :sub:`2` > + - r\ :sub:`1` > + - r\ :sub:`0` > + * .. _MEDIA-BUS-FMT-SGRBG20-1X20: > + > + - MEDIA_BUS_FMT_SGRBG20_1X20 > + - 0x3023 > + - > + - r\ :sub:`19` > + - r\ :sub:`18` > + - r\ :sub:`17` > + - r\ :sub:`16` > + - r\ :sub:`15` > + - r\ :sub:`14` > + - r\ :sub:`13` > + - r\ :sub:`12` > + - r\ :sub:`11` > + - r\ :sub:`10` > + - r\ :sub:`9` > + - r\ :sub:`8` > + - r\ :sub:`7` > + - r\ :sub:`6` > + - r\ :sub:`5` > + - r\ :sub:`4` > + - r\ :sub:`3` > + - r\ :sub:`2` > + - r\ :sub:`1` > + - r\ :sub:`0` > + * .. _MEDIA-BUS-FMT-SRGGB20-1X20: > + > + - MEDIA_BUS_FMT_SRGGB20_1X20 > + - 0x3024 > + - > + - r\ :sub:`19` > + - r\ :sub:`18` > + - r\ :sub:`17` > + - r\ :sub:`16` > + - r\ :sub:`15` > + - r\ :sub:`14` > + - r\ :sub:`13` > + - r\ :sub:`12` > + - r\ :sub:`11` > + - r\ :sub:`10` > + - r\ :sub:`9` > + - r\ :sub:`8` > + - r\ :sub:`7` > + - r\ :sub:`6` > + - r\ :sub:`5` > + - r\ :sub:`4` > + - r\ :sub:`3` > + - r\ :sub:`2` > + - r\ :sub:`1` > + - r\ :sub:`0` > > .. raw:: latex > > diff --git a/include/uapi/linux/media-bus-format.h b/include/uapi/linux/media-bus-format.h > index 49be328d9a3b..b6acf8c8e383 100644 > --- a/include/uapi/linux/media-bus-format.h > +++ b/include/uapi/linux/media-bus-format.h > @@ -122,7 +122,7 @@ > #define MEDIA_BUS_FMT_YUV16_1X48 0x202a > #define MEDIA_BUS_FMT_UYYVYY16_0_5X48 0x202b > > -/* Bayer - next is 0x3021 */ > +/* Bayer - next is 0x3025 */ > #define MEDIA_BUS_FMT_SBGGR8_1X8 0x3001 > #define MEDIA_BUS_FMT_SGBRG8_1X8 0x3013 > #define MEDIA_BUS_FMT_SGRBG8_1X8 0x3002 > @@ -155,6 +155,10 @@ > #define MEDIA_BUS_FMT_SGBRG16_1X16 0x301e > #define MEDIA_BUS_FMT_SGRBG16_1X16 0x301f > #define MEDIA_BUS_FMT_SRGGB16_1X16 0x3020 > +#define MEDIA_BUS_FMT_SBGGR20_1X20 0x3021 > +#define MEDIA_BUS_FMT_SGBRG20_1X20 0x3022 > +#define MEDIA_BUS_FMT_SGRBG20_1X20 0x3023 > +#define MEDIA_BUS_FMT_SRGGB20_1X20 0x3024 > > /* JPEG compressed formats - next is 0x4002 */ > #define MEDIA_BUS_FMT_JPEG_1X8 0x4001 -- Regards, Laurent Pinchart
