Re: [PATCH v2 2/6] dt-bindings: iio: chemical: add ENS160 sensor

[Conor Dooley <conor@xxxxxxxxxx>]

On Tue, May 28, 2024 at 09:14:19PM -0300, Gustavo Silva wrote:
> Add bindings for ScioSense ENS160 multi-gas sensor.
> 
> Datasheet: https://www.sciosense.com/wp-content/uploads/2023/12/ENS160-Datasheet.pdf
> 
> Signed-off-by: Gustavo Silva <gustavograzs@xxxxxxxxx>
> ---
> changes in v2:
>  - Add devicetree binding file specifically for this sensor instead of
>    adding it to trivial-devices.yaml. This is needed in order to
>    document that this chip supports Vdd and Vddio supplies.
>  .../iio/chemical/sciosense,ens160.yaml        | 68 +++++++++++++++++++
>  1 file changed, 68 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/chemical/sciosense,ens160.yaml
> 
> diff --git a/Documentation/devicetree/bindings/iio/chemical/sciosense,ens160.yaml b/Documentation/devicetree/bindings/iio/chemical/sciosense,ens160.yaml
> new file mode 100644
> index 000000000..7dd442f94
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/chemical/sciosense,ens160.yaml
> @@ -0,0 +1,68 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/chemical/sciosense,ens160.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ScioSense ENS160 multi-gas sensor
> +
> +maintainers:
> +  - Gustavo Silva <gustavograzs@xxxxxxxxx>
> +
> +description: |
> +  Digital Multi-Gas Sensor for Monitoring Indoor Air Quality.
> +
> +  Datasheet:
> +    https://www.sciosense.com/wp-content/uploads/2023/12/ENS160-Datasheet.pdf
> +
> +properties:
> +  compatible:
> +    enum:
> +      - sciosense,ens160
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  vdd-supply: true
> +  vddio-supply: true
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    i2c {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +
> +      gas-sensor@52 {
> +        compatible = "sciosense,ens160";
> +        reg = <0x52>;
> +        interrupt-parent = <&gpio0>;
> +        interrupts = <19 IRQ_TYPE_EDGE_FALLING>;
> +      };
> +    };
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +
> +    spi {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +
> +      gas-sensor@0 {
> +        compatible = "sciosense,ens160";
> +        reg = <0>;
> +        spi-max-frequency = <10000000>;

If you want to include this, you need to add an
allOf:
  - $ref: /schemas/spi/spi-peripheral-props.yaml#
above. Otherwise this looks pretty good, so with that added
Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>

Thanks,
Conor.

Attachment: signature.asc
Description: PGP signature