On Sat, May 25, 2024 at 06:21:32PM +0100, Conor Dooley wrote: > On Tue, May 21, 2024 at 11:38:01AM -0700, Elliot Berman wrote: > > #define QCOM_BOARD_ID(a, major, minor) \ > > - (((major & 0xff) << 16) | ((minor & 0xff) << 8) | QCOM_BOARD_ID_##a) > > + (((major & 0xff) << 16) | ((minor & 0xff) << 8) | ((QCOM_BOARD_ID_##a) & 0xff)) > > I assume there's no devices that have a >8 bit QCOM_BOARD_ID that would > end up with a different value in their dtb due to this change? That's correct.