> On 18/05/2024 13:31, Lorenzo Bianconi wrote: > > Introduce device-tree binding documentation for Airoha EN7581 PCIe PHY > > driver. > > > > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx> > > Tested-by: Zhengping Zhang <zhengping.zhang@xxxxxxxxxx> > > How the binding was tested? > > > Signed-off-by: Lorenzo Bianconi <lorenzo@xxxxxxxxxx> > > A nit, subject: drop second/last, redundant "bindings". The > "dt-bindings" prefix is already stating that these are bindings. > See also: > https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18 > > Subject: drop driver. This is for hardware, not drivers. > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Do I need to repost it or is it ok to address it applying the patches? Regards, Lorenzo > > Best regards, > Krzysztof >
Attachment:
signature.asc
Description: PGP signature