On Wed, May 29, 2024 at 06:02:56PM +0800, Tengfei Fan wrote: > Otg is default usb dr_mode, so this property can be removed. OTG, not Otg. With that fixed: Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > > Signed-off-by: Tengfei Fan <quic_tengfan@xxxxxxxxxxx> > --- > arch/arm64/boot/dts/qcom/sm8550-hdk.dts | 4 ---- > arch/arm64/boot/dts/qcom/sm8550-mtp.dts | 4 ---- > arch/arm64/boot/dts/qcom/sm8550-qrd.dts | 4 ---- > arch/arm64/boot/dts/qcom/sm8550-sony-xperia-yodo-pdx234.dts | 4 ---- > 4 files changed, 16 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8550-hdk.dts b/arch/arm64/boot/dts/qcom/sm8550-hdk.dts > index 411de3451db8..e0dc03a97771 100644 > --- a/arch/arm64/boot/dts/qcom/sm8550-hdk.dts > +++ b/arch/arm64/boot/dts/qcom/sm8550-hdk.dts > @@ -1253,10 +1253,6 @@ &usb_1 { > status = "okay"; > }; > > -&usb_1_dwc3 { > - dr_mode = "otg"; > -}; > - > &usb_1_dwc3_hs { > remote-endpoint = <&pmic_glink_hs_in>; > }; > diff --git a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts > index 84d16227ef80..26dfca0c3e05 100644 > --- a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts > +++ b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts > @@ -946,10 +946,6 @@ &usb_1 { > status = "okay"; > }; > > -&usb_1_dwc3 { > - dr_mode = "otg"; > -}; > - > &usb_1_dwc3_hs { > remote-endpoint = <&pmic_glink_hs_in>; > }; > diff --git a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts > index e20c6240f76d..d27820fb5fc0 100644 > --- a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts > +++ b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts > @@ -1115,10 +1115,6 @@ &usb_1 { > status = "okay"; > }; > > -&usb_1_dwc3 { > - dr_mode = "otg"; > -}; > - > &usb_1_dwc3_hs { > remote-endpoint = <&pmic_glink_hs_in>; > }; > diff --git a/arch/arm64/boot/dts/qcom/sm8550-sony-xperia-yodo-pdx234.dts b/arch/arm64/boot/dts/qcom/sm8550-sony-xperia-yodo-pdx234.dts > index 6dd5232da9f9..85d487ef80a0 100644 > --- a/arch/arm64/boot/dts/qcom/sm8550-sony-xperia-yodo-pdx234.dts > +++ b/arch/arm64/boot/dts/qcom/sm8550-sony-xperia-yodo-pdx234.dts > @@ -737,10 +737,6 @@ &usb_1 { > status = "okay"; > }; > > -&usb_1_dwc3 { > - dr_mode = "otg"; > -}; > - > &usb_1_dwc3_hs { > remote-endpoint = <&pmic_glink_hs_in>; > }; > -- > 2.25.1 > -- With best wishes Dmitry