On 29/05/2024 10:19, Alexandre Bailon wrote: > > > On 5/27/24 08:56, Krzysztof Kozlowski wrote: >> On 24/05/2024 16:31, Alexandre Bailon wrote: >>> This uses the thermal aggregation for the mt8195 to get the maximal >>> temperature of big and little cpu clusters. >>> >>> Signed-off-by: Alexandre Bailon <abailon@xxxxxxxxxxxx> >>> --- >>> arch/arm64/boot/dts/mediatek/mt8195.dtsi | 212 +++-------------------- >>> 1 file changed, 27 insertions(+), 185 deletions(-) >>> >>> diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi >>> index 5d8b68f86ce4..8aa2bf142622 100644 >>> --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi >>> +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi >>> @@ -3600,50 +3600,31 @@ dp_tx: dp-tx@1c600000 { >>> }; >>> >>> thermal_zones: thermal-zones { >>> - cpu0-thermal { >>> + cpu-little { >> >> How is it related to the commit? > To aggregate all thermal sensors which are in same performance domain, > we removes each individual nodes to create only two: cpu-little and cpu-big. OK... > We need to remove the other nodes because their trips points and cooling > devices would conflict with those we define for the multi sensor thermal > zone. > > Best Regards, > Alexandre >> >> Does not look tested. You just introduced warnings. Yet still I claim it wasn't tested. See SoC maintainer profile documents and/or writing-schema. Best regards, Krzysztof