According to the GPIO regulator DT bindings[1], the default GPIO state
is LOW. However, the driver defaults to HIGH.
Before the conversion to descriptors in commit d6cd33ad71029a3f
("regulator: gpio: Convert to use descriptors"), the default state used
by the driver was rather ill-defined, too:
- If the "gpio-states" property was missing or empty, the default was
low, matching the bindings.
- If the "gpio-states" property was present, the default for missing
entries was the value of the last present entry.
Fix this by making the driver adhere to the DT bindings, i.e. default to
LOW.
[1] Documentation/devicetree/bindings/regulator/gpio-regulator.yaml
Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
---
I have no idea if this has any impact.
I guess most/all DTS files have proper gpios-states properties?
v2:
- Add Acked-by.
---
drivers/regulator/gpio-regulator.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/regulator/gpio-regulator.c b/drivers/regulator/gpio-regulator.c
index 65927fa2ef161cda..5dfed8bae0c4cfdc 100644
--- a/drivers/regulator/gpio-regulator.c
+++ b/drivers/regulator/gpio-regulator.c
@@ -176,9 +176,9 @@ of_get_gpio_regulator_config(struct device *dev, struct device_node *np,
ret = of_property_read_u32_index(np, "gpios-states", i,
&val);
- /* Default to high per specification */
+ /* Default to low per specification */
if (ret)
- config->gflags[i] = GPIOD_OUT_HIGH;
+ config->gflags[i] = GPIOD_OUT_LOW;
else
config->gflags[i] =
val ? GPIOD_OUT_HIGH : GPIOD_OUT_LOW;
--
2.34.1
