Re: [PATCH 01/10] dt-bindings: clock: qcom: split the non-PD schema for GCC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 28/05/2024 22:43, Dmitry Baryshkov wrote:
> On some of Qualcomm platforms the Global Clock Controller (GCC) doesn't
> provide power domains. Split no-PD version from the common qcom,gcc schema.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> ---


> diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc.yaml
> index 788825105f24..e7ec15b1780d 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,gcc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,gcc.yaml
> @@ -14,27 +14,14 @@ description: |
>    Common bindings for Qualcomm global clock control module providing the
>    clocks, resets and power domains.
>  
> -properties:
> -  '#clock-cells':
> -    const: 1
> -
> -  '#reset-cells':
> -    const: 1
> +allOf:
> +  - $ref: qcom,gcc-nopd.yaml
>  
> +properties:
>    '#power-domain-cells':
>      const: 1

So what's left here? One property? Not much benefit. Triple-schema
(include something to include something) does not make it readable. Just
do not require power-domain-cells in qcom,gcc.yaml.


Best regards,
Krzysztof





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux