On Tue, May 28, 2024 at 03:41:48PM -0500, Rob Herring (Arm) wrote: > > On Tue, 28 May 2024 22:03:11 +0300, Laurent Pinchart wrote: > > The ADP5585 is a 10/11 input/output port expander with a built in keypad > > matrix decoder, programmable logic, reset generator, and PWM generator. > > These bindings model the device as an MFD, and support the GPIO expander > > and PWM functions. > > > > These bindings support the GPIO and PWM functions. > > > > Drop the existing adi,adp5585 and adi,adp5585-02 compatible strings from > > trivial-devices.yaml. They have been added there by mistake as the > > driver that was submitted at the same time used different compatible > > strings. We can take them over safely. > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > --- > > I've limited the bindings to GPIO and PWM as I lack hardware to design, > > implement and test the rest of the features the chip supports. > > > > Changes since v1: > > > > - Squash "dt-bindings: trivial-devices: Drop adi,adp5585 and > > adi,adp5585-02" into this patch > > - Merge child nodes into parent node > > --- > > .../devicetree/bindings/mfd/adi,adp5585.yaml | 107 ++++++++++++++++++ > > .../devicetree/bindings/trivial-devices.yaml | 4 - > > MAINTAINERS | 7 ++ > > 3 files changed, 114 insertions(+), 4 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/mfd/adi,adp5585.yaml > > > > My bot found errors running 'make dt_binding_check' on your patch: My bad, I messed up. Will be fixed in v3. > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/adi,adp5585.example.dtb: mfd@34: 'gpio' is a required property > from schema $id: http://devicetree.org/schemas/mfd/adi,adp5585.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/adi,adp5585.example.dtb: mfd@34: 'gpio' is a required property > from schema $id: http://devicetree.org/schemas/mfd/adi,adp5585.yaml# > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240528190315.3865-2-laurent.pinchart@xxxxxxxxxxxxxxxx > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. > -- Regards, Laurent Pinchart
